Skip to content

Update READLINE_ARCH #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
e-wang wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update READLINE_ARCH #379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b62a5f6
Use Hardware::CPU.arch instead of MacOS.preferred_arch for READLINE_ARCH
e-wang Jul 12, 2020
c6c32ba
Update style guide link in CONTRIBUTING
e-wang Jul 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,4 +158,4 @@ When updating Rubygems for gitsh, there are a few things to consider:
- Use the minimum supported Ruby version when updating gems to avoid
installing versions that are incompatible with older Rubies.

[style-guide]: https://github.com/thoughtbot/guides/tree/master/style#ruby
[style-guide]: https://github.com/thoughtbot/guides/tree/master/ruby
2 changes: 1 addition & 1 deletion homebrew/gitsh.rb.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,6 @@ class Gitsh < Formula
end

def set_architecture
ENV['READLINE_ARCH'] = "-arch #{MacOS.preferred_arch}"
ENV['READLINE_ARCH'] = "-arch #{Hardware::CPU.arch}"
end
end