Skip to content

Support installing gitsh from HEAD via Homebrew #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sharplet wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support installing gitsh from HEAD via Homebrew #368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72738d4
Support installing gitsh from HEAD via Homebrew
sharplet Apr 28, 2019
579b602
fixup! Support installing gitsh from HEAD via Homebrew
sharplet Apr 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ AC_PREREQ([2.68])
AC_INIT(gitsh, 0.14, hello@thoughtbot.com)
AM_INIT_AUTOMAKE([subdir-objects])

AC_ARG_VAR([VERSION_SUFFIX], [Appended to PACKAGE_VERSION when building, e.g., for pre-release builds])
AS_IF([test -n "$VERSION_SUFFIX"], [AC_SUBST([PACKAGE_VERSION], ["$PACKAGE_VERSION$VERSION_SUFFIX"])])

AC_ARG_VAR([RUBY],[The path of the Ruby binary to use])
AC_ARG_VAR(
[READLINE_LIB],
Expand Down
13 changes: 13 additions & 0 deletions homebrew/gitsh.rb.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,12 @@ class Gitsh < Formula
url 'https://thoughtbot.github.io/@PACKAGE@/@DIST_ARCHIVES@'
sha256 '@DIST_SHA@'

head do
url 'https://github.com/thoughtbot/@PACKAGE@.git'
depends_on 'autoconf' => :build
depends_on 'automake' => :build
end

def self.old_system_ruby?
system_ruby_version = `#{SYSTEM_RUBY_PATH} -e "puts RUBY_VERSION"`.chomp
system_ruby_version < '2.3.0'
Expand All @@ -22,6 +28,13 @@ class Gitsh < Formula
def install
set_ruby_path
set_architecture

if build.head?
system "./autogen.sh"
git_sha = %x(git log -1 --format=%h).chomp
ENV["VERSION_SUFFIX"] = "-head+#{git_sha}"
end

system "./configure", "--disable-debug",
"--disable-dependency-tracking",
"--disable-silent-rules",
Expand Down