This repository was archived by the owner on Feb 12, 2025. It is now read-only.
Encode reponse in UTF-8 to fix JSON parse error#25
Open
stefan-lz wants to merge 3 commits into
Open
Conversation
Response was encoded in ASCII, and the JSON parser could not understand the UTF8's BOM Also: - have introduced using ENV variable to store API key. - have filtered sensitive API key details from vcr. - have replayed vcr cassettes and updated tests.
Author
|
All tests are now passing on travis :) You might want to run the vcr cassettes again yourself - incase you get different results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Response was encoded in ASCII, and the JSON parser could
not understand the UTF8's BOM in the response body.
Also:
Cheers,