Move keyboard-capture indicator from over-video badge to toolbar#37
Merged
Conversation
The "All keys" / "Limited keys" / "Capture off" status was a badge floating over the top-right of the remote video, shown only in fullscreen. Surface it in the window toolbar instead so the remote display stays free of persistent chrome, and show it in both windowed and fullscreen modes. A new CaptureStatusDisplay enum distinguishes the actionable fullscreen-limited state (tappable, opens Accessibility settings) from the normal windowed-limited state (calm, non-interactive). The transient triple-Esc banner on entering fullscreen is preserved. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The keyboard-capture status ("All keys" / "Limited keys" / "Capture off") was a badge floating over the remote video and shown only in fullscreen; it now lives in the window toolbar in both windowed and fullscreen modes, keeping the remote display free of persistent chrome. A new
CaptureStatusDisplayenum distinguishes the actionable fullscreen-limited state (tappable → opens Accessibility settings, orange) from the normal windowed-limited state (calm, non-interactive) and the off state. The transient triple-Esc hint banner on entering fullscreen is preserved. All changes are inKVMConsole/UI/ViewerView.swift; the macOS test suite passes.🤖 Generated with Claude Code