Conversation
e53982a to
6d4527d
Compare
6d4527d to
7e87ba9
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1909 +/- ##
===========================================
- Coverage 65.24% 65.08% -0.17%
===========================================
Files 195 196 +1
Lines 9386 9423 +37
===========================================
+ Hits 6124 6133 +9
- Misses 3262 3290 +28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
NoelLH
left a comment
There was a problem hiding this comment.
There is I think a wider question on the cost/benefit of not using their SDK for future stages, but doesn't block merging this.
| * rather than the Ryft PHP SDK as that doesn't seem to add any real value - it isn't usable | ||
| * without referring in detail to documentation provided separately. |
There was a problem hiding this comment.
Have we checked if it has features like auto pagination, retries etc. like Stripe's?
Right, will reply on existing slack thread about that. It doesn't look like the SDK does do pagination or retries - see e.g. the list customer function here, which just delegates to a single call to the http client (although it does have some helpful parameters in that case https://github.com/RyftPay/ryft-php/blob/e77c6cc226fa98333e97f335e77b9e8c28bfad44/lib/Ryft/Api/Customers/CustomersClient.php#L23 ) |
When creating a donation this will now call Ryft if the charity is set up on Ryft to get a client secret, and pass that secret on to the frontend for use in the donation form.