Skip to content

Bg2 3106 donate with ryft#1909

Merged
bdsl merged 3 commits intodevelopfrom
BG2-3106-donate-with-ryft
Apr 2, 2026
Merged

Bg2 3106 donate with ryft#1909
bdsl merged 3 commits intodevelopfrom
BG2-3106-donate-with-ryft

Conversation

@bdsl
Copy link
Copy Markdown
Contributor

@bdsl bdsl commented Apr 1, 2026

When creating a donation this will now call Ryft if the charity is set up on Ryft to get a client secret, and pass that secret on to the frontend for use in the donation form.

@bdsl bdsl force-pushed the BG2-3106-donate-with-ryft branch from e53982a to 6d4527d Compare April 1, 2026 16:54
@bdsl bdsl force-pushed the BG2-3106-donate-with-ryft branch from 6d4527d to 7e87ba9 Compare April 1, 2026 16:58
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 29.26829% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.08%. Comparing base (daabdf8) to head (62002be).
⚠️ Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
src/Client/RyftClient.php 20.68% 23 Missing ⚠️
src/Application/Actions/Donations/Create.php 50.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1909      +/-   ##
===========================================
- Coverage    65.24%   65.08%   -0.17%     
===========================================
  Files          195      196       +1     
  Lines         9386     9423      +37     
===========================================
+ Hits          6124     6133       +9     
- Misses        3262     3290      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@NoelLH NoelLH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is I think a wider question on the cost/benefit of not using their SDK for future stages, but doesn't block merging this.

Comment on lines +15 to +16
* rather than the Ryft PHP SDK as that doesn't seem to add any real value - it isn't usable
* without referring in detail to documentation provided separately.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we checked if it has features like auto pagination, retries etc. like Stripe's?

@bdsl
Copy link
Copy Markdown
Contributor Author

bdsl commented Apr 2, 2026

There is I think a wider question on the cost/benefit of not using their SDK for future stages, but doesn't block merging this.

Right, will reply on existing slack thread about that. It doesn't look like the SDK does do pagination or retries - see e.g. the list customer function here, which just delegates to a single call to the http client (although it does have some helpful parameters in that case https://github.com/RyftPay/ryft-php/blob/e77c6cc226fa98333e97f335e77b9e8c28bfad44/lib/Ryft/Api/Customers/CustomersClient.php#L23 )

@bdsl bdsl merged commit 152d9ca into develop Apr 2, 2026
4 checks passed
@bdsl bdsl deleted the BG2-3106-donate-with-ryft branch April 2, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants