Conversation
Includes switching to our fork of los/los-rate-limit to remove declared dependency on old laminas/diactoros that in turn depends on PHP 8.3 or older
Should be no breaking changes in this API version, see https://github.com/stripe/stripe-php/tree/v19.3.0
Should stop deprecation messages currently being output when running integration tests: [13-Feb-2026 15:40:49 UTC] PHP Deprecated: MatchBot\IntegrationTests\IntegrationTest::addCampaignAndCharityToDB(): Implicitly marking parameter $charitySfId as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/integrationTests/IntegrationTest.php on line 297 [13-Feb-2026 15:40:49 UTC] PHP Deprecated: MatchBot\Tests\Application\DonationTestDataTrait::getTestDonation(): Implicitly marking parameter $tbgGiftAidRequestConfirmedCompleteAt as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/****s/Application/DonationTestDataTrait.php on line 92 PHPUnit 9.6.34 by Sebastian Bergmann and contributors. Random Seed: 1770997249 [13-Feb-2026 15:40:49 UTC] PHP Deprecated: MatchBot\Tests\TestCase::someCampaign(): Implicitly marking parameter $thankYouMessage as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/****s/TestCase.php on line 411 [13-Feb-2026 15:40:49 UTC] PHP Deprecated: MatchBot\Tests\TestCase::someCampaign(): Implicitly marking parameter $metaCampaignSlug as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/****s/TestCase.php on line 412 [13-Feb-2026 15:40:49 UTC] PHP Deprecated: MatchBot\Tests\TestCase::someDonation(): Implicitly marking parameter $uuid as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/****s/TestCase.php on line 455 [13-Feb-2026 15:40:49 UTC] PHP Deprecated: MatchBot\Domain\CampaignRepository::findOneBySalesforceId(): Implicitly marking parameter $mustBeUpdatedSince as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/src/Domain/CampaignRepository.php on line 128 [13-Feb-2026 15:40:49 UTC] PHP Deprecated: MatchBot\Domain\RegularGivingMandate::createPreAuthorizedDonation(): Implicitly marking parameter $expectedActivationDate as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/src/Domain/RegularGivingMandate.php on line 310
BG2-3023: Upgrade PHP from 8.3 to 8.5
…orized PHPStan then forced me to stop discarding the return value in tests
Refactor - add NoDiscard attribute to DonationService::confirmPreAuth…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.