Skip to content

stop relying on file access api to donwload a json #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
diegodorado wants to merge 1 commit into
base: main
Choose a base branch
from
Open

stop relying on file access api to donwload a json #333

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 23 additions & 32 deletions src/components/panes/configure-panes/save-load.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,47 +109,38 @@ export const Pane: FC = () => {
};

const saveLayout = async () => {
const {name, vendorProductId} = selectedDefinition;
const suggestedName =
name.replace(/[^a-zA-Z0-9]/g, '_').toLowerCase() + '.layout.json';
try {
const handle = await window.showSaveFilePicker({
suggestedName,
});
const encoderValues = await getEncoderValues();
const saveFile: ViaSaveFile = {
name,
vendorProductId,
macros: [...expressions],
layers: rawLayers.map(
(layer: {keymap: number[]}) =>
layer.keymap.map(
(keyByte: number) =>
getCodeForByte(keyByte, basicKeyToByte, byteToKey) || '',
), // TODO: should empty string be empty keycode instead?
),
encoders: encoderValues,
};
const { name, vendorProductId } = selectedDefinition;

const content = stringify(saveFile);
const blob = new Blob([content], {type: 'application/json'});
const writable = await handle.createWritable();
await writable.write(blob);
await writable.close();
} catch (err) {
console.log('User cancelled save file request');
}
const encoderValues = await getEncoderValues();
const saveFile: ViaSaveFile = {
name,
vendorProductId,
macros: [...expressions],
layers: rawLayers.map(
(layer: { keymap: number[] }) =>
layer.keymap.map(
(keyByte: number) =>
getCodeForByte(keyByte, basicKeyToByte, byteToKey) || '',
), // TODO: should empty string be empty keycode instead?
),
encoders: encoderValues,
};

const content = stringify(saveFile);
const blob = new Blob([content], { type: 'application/json' });

/*
const url = URL.createObjectURL(blob);

const suggestedName =
name.replace(/[^a-zA-Z0-9]/g, '_').toLowerCase() + '.layout.json';

const link = document.createElement('a');
link.href = url;
link.download = defaultFilename;
link.download = suggestedName;

link.click();
URL.revokeObjectURL(url);
*/

};

const loadLayout = ([file]: Blob[]) => {
Expand Down