Added preloader to avoid network calls and computationally expensive scaling between scenes#55
Open
VictorSohier wants to merge 3 commits intomainfrom
Open
Added preloader to avoid network calls and computationally expensive scaling between scenes#55VictorSohier wants to merge 3 commits intomainfrom
VictorSohier wants to merge 3 commits intomainfrom
Conversation
rodneybarnes
reviewed
Sep 5, 2021
| setup() {} | ||
| preload() | ||
| { | ||
| let promises = [ |
Contributor
There was a problem hiding this comment.
Will this be made redundant by GateFactory.preload() in #51 ?
Member
Author
There was a problem hiding this comment.
Yes it will, it is basically all thrown into the gate factory preloader, that mess is for demonstration purposes.
rodneybarnes
reviewed
Sep 5, 2021
| { | ||
| canvasManager.createCanvas(); | ||
| sceneManager.setCurrentScene(MAIN_MENU); | ||
| let promises = []; |
Contributor
There was a problem hiding this comment.
There seems to be a lot of noise in this PR, is this the heart of the changes you're making here?
Member
Author
There was a problem hiding this comment.
I'll look into the noise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Added a preload function to scenes.
This is meant to load all assets into memory before the program runs.
Closes #48
How to use
In a given scene class:
How to test this PR:
If this solution does as I say it does, all assets for the cheatsheet and challenge mode pages should not be loaded on scene switch, but instead, on page load.
Checklist: