This repository was archived by the owner on Jan 8, 2025. It is now read-only.
Open
Conversation
Author
|
Test still fails, but somehow seems to be in a non-related part of the code? Not sure what to think of this. Either way I think a check is missing in reverse_url@statik/views.py, about whether the path is a file or a directory. I did a dirty fix in that it just checks for "*.js", and the data-simple example renders correctly. Obviously, all other file extensions are missing. |
Owner
|
Thanks for the PR! Let's get the tests passing though 😁 I'll investigate too. |
Author
|
I'm extra confused here because the following command: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was removed in a previous commit, but it breaks urls for some reason, as described in #49.
I just restored this line from cdc675b, where it was still working