Skip to content
This repository was archived by the owner on Jan 8, 2025. It is now read-only.

fix #49#53

Open
dcferreira wants to merge 2 commits intothanethomson:masterfrom
dcferreira:master
Open

fix #49#53
dcferreira wants to merge 2 commits intothanethomson:masterfrom
dcferreira:master

Conversation

@dcferreira
Copy link

This was removed in a previous commit, but it breaks urls for some reason, as described in #49.
I just restored this line from cdc675b, where it was still working

@dcferreira
Copy link
Author

Test still fails, but somehow seems to be in a non-related part of the code? Not sure what to think of this.

Either way I think a check is missing in reverse_url@statik/views.py, about whether the path is a file or a directory. I did a dirty fix in that it just checks for "*.js", and the data-simple example renders correctly. Obviously, all other file extensions are missing.

@thanethomson
Copy link
Owner

Thanks for the PR! Let's get the tests passing though 😁 I'll investigate too.

@dcferreira
Copy link
Author

I'm extra confused here because the following command:
git clone https://github.com/thanethomson/statik.git statik_tmp && cd statik_tmp && python -m unittest discover
fails with the same error that travis throws now (even though the latest commit in master passed the tests, according to travis).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants