-
Notifications
You must be signed in to change notification settings - Fork 118
Windows 7 #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Windows 7 #183
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
cb2551d
Builds
Mothblocks 155c8dc
CI - 1
Mothblocks ff049b4
2 - Try not specifying target?
Mothblocks 8fcda8d
3 - Change config.toml, temp remove rust-cache
Mothblocks fafed49
4 - include rust-src
Mothblocks 0d971fc
5 - Use usual Windows 32-bit target for clippy, since it doesn't need…
Mothblocks e424cdd
6 - Box errors
Mothblocks ef2fb50
7 - We really should be boxing errors but this will make clippy happy…
Mothblocks af6c288
8 - Does this fix it
Mothblocks d47cdd3
9 - Fix redis lint
Mothblocks 5a4ad96
Update README.md
Mothblocks 65aff63
We don't build for Win7 by default, just CI
Mothblocks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,8 @@ | ||
| [target.i686-pc-windows-msvc] | ||
| rustflags = ["-C", "target-feature=+crt-static"] | ||
|
|
||
| [target.i686-win7-windows-msvc] | ||
| rustflags = ["-C", "target-feature=+crt-static"] | ||
|
|
||
| [target.x86_64-pc-windows-msvc] | ||
| rustflags = ["-C", "target-feature=+crt-static"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For those unaware of why we are building std and thus using a nightly toolchain,
rust-lang/rust#118150