Open
Conversation
Clarified the description of the `subnets` array to include IPv6 address prefixes and improved explanation of its application.
tfpauly
commented
Apr 2, 2026
yaroslavros
reviewed
Apr 2, 2026
| The `subnets` array includes IPv4 and IPv6 address literals, as well as IPv4 and IPv6 address subnets | ||
| written using CIDR notation {{?CIDR=RFC4632}}. Subnet-based destination information can apply to cases where | ||
| The `subnets` array includes IPv4 and IPv6 address literals, as well as IPv4 address subnets | ||
| represented using CIDR notation {{!CIDR=RFC4632}} and IPv6 address prefixes {{Section 2.3 of !RFC4291}}. |
Collaborator
There was a problem hiding this comment.
Suggested change
| represented using CIDR notation {{!CIDR=RFC4632}} and IPv6 address prefixes {{Section 2.3 of !RFC4291}}. | |
| represented using CIDR notation {{!CIDR=RFC4632}} and IPv6 address prefixes {{Section 2.3 of !IPv6-ADDR=RFC4291}}. |
Collaborator
|
Looks good. One minor suggestion to avoid overwhelming reader with all the RFC numbers across various technologies. |
yaroslavros
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarified the description of the
subnetsarray to include IPv6 address prefixes and improved explanation of its application.Addresses TSVART review: https://datatracker.ietf.org/doc/review-ietf-intarea-proxy-config-11-tsvart-telechat-eddy-2026-03-27/