Skip to content

Conversation

@jjuhl
Copy link
Contributor

@jjuhl jjuhl commented Jan 11, 2026

Looking at what is the common style in CMake files reveals that one should not have a space between the 'if' and the actual condition. That clashes very much with what I personally prefer, but maintaining concistency is much more important. So, here's a commit that makes the style consistent.

@texus
Copy link
Owner

texus commented Jan 11, 2026

There are also CMakeLists.txt files in tests/, src/Backend and src/ where similar changes can be made.

You accidentally changed a line in examples/main-SFML_GRAPHICS.cpp, which isn't a cmake file.

@jjuhl
Copy link
Contributor Author

jjuhl commented Jan 11, 2026

Thank you for the feedback. I'll fix that up and update the PR.

Looking at what is the common style in CMake files reveals that one
should not have a space between the 'if' and the actual condition.
That clashes very much with what I personally prefer, but maintaining
concistency is much more important. So, here's a commit that makes the
style consistent.
@texus texus merged commit ee860e0 into texus:1.x Jan 14, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants