fix: remove libertine-font to resolve Chinese double-quote rendering issue#63
Open
Utkal059 wants to merge 1 commit intotexmacs:mainfrom
Open
fix: remove libertine-font to resolve Chinese double-quote rendering issue#63Utkal059 wants to merge 1 commit intotexmacs:mainfrom
Utkal059 wants to merge 1 commit intotexmacs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Chinese double-quote rendering issue reported in MoganLab/mogan#2231.
The problem was that
notes.tsspecifieslibertine-fontin theuse-packagedeclaration (line 23), but Libertine doesn't have glyphs for Chinese double
quotes (""), so they fail to render in
/src/main.tm.The fix is straightforward — just remove
libertine-fontfrom the package list,so the system falls back to a CJK-compatible font that can handle these characters.
I found this through @Tenktau's analysis in the original issue — they already
identified the root cause and suggested this exact change. I verified it matches
the code at line 23.
This is my first contribution to the texmacs/notes project. I'm working on
Mogan STEM as part of my GSoC 2026 preparation and picked this up from the
open issues. Happy to adjust anything!