Skip to content

Remove ESM-only get-port dependency path#1378

Merged
cristianrgreco merged 1 commit into
mainfrom
codex/remove-esm-get-port-path
Jun 19, 2026
Merged

Remove ESM-only get-port dependency path#1378
cristianrgreco merged 1 commit into
mainfrom
codex/remove-esm-get-port-path

Conversation

@cristianrgreco

Copy link
Copy Markdown
Collaborator

Summary

  • Downgrade get-port to the CommonJS-compatible 5.1.1 line.
  • Add a Dependabot ignore rule so get-port is not automatically raised back to ESM-only major versions.
  • Remove the ChromaDB module's dev dependency on @chroma-core/ollama, which pulled in an older published testcontainers package and reintroduced get-port@7 through a dev-only transitive path.
  • Keep the ChromaDB embedding-function example covered by using a small local EmbeddingFunction that calls Ollama's /api/embed endpoint directly.

Verification

  • npm install --ignore-scripts
  • npm run format
  • npm run lint
  • npm run -w testcontainers build
  • npm run -w @testcontainers/chromadb build

Test results

  • Formatting and linting passed.
  • The core testcontainers package build passed.
  • The @testcontainers/chromadb package build passed after building the referenced core package.

Semver impact

Patch. This does not change the public API. The get-port usage in this repository only needs the default port-selection function, which is available in get-port@5.1.1; the downgrade removes the ESM-only package surface from CommonJS/Jest consumers. The ChromaDB dependency removal affects only module tests/docs and removes an unnecessary dev dependency path, not published runtime behavior.

@netlify

netlify Bot commented Jun 19, 2026

Copy link
Copy Markdown

Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit 372d4c8
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-node/deploys/6a352c85e8423400084b358e
😎 Deploy Preview https://deploy-preview-1378--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@cristianrgreco cristianrgreco added dependencies Pull requests that update a dependency file patch Backward compatible bug fix labels Jun 19, 2026
@cristianrgreco cristianrgreco merged commit 5cae5cf into main Jun 19, 2026
263 checks passed
@cristianrgreco cristianrgreco deleted the codex/remove-esm-get-port-path branch June 19, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file patch Backward compatible bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant