Remove ESM-only get-port dependency path#1378
Merged
Merged
Conversation
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get-portto the CommonJS-compatible5.1.1line.get-portis not automatically raised back to ESM-only major versions.@chroma-core/ollama, which pulled in an older publishedtestcontainerspackage and reintroducedget-port@7through a dev-only transitive path.EmbeddingFunctionthat calls Ollama's/api/embedendpoint directly.Verification
npm install --ignore-scriptsnpm run formatnpm run lintnpm run -w testcontainers buildnpm run -w @testcontainers/chromadb buildTest results
testcontainerspackage build passed.@testcontainers/chromadbpackage build passed after building the referenced core package.Semver impact
Patch. This does not change the public API. The
get-portusage in this repository only needs the default port-selection function, which is available inget-port@5.1.1; the downgrade removes the ESM-only package surface from CommonJS/Jest consumers. The ChromaDB dependency removal affects only module tests/docs and removes an unnecessary dev dependency path, not published runtime behavior.