Move tangent/knot visibility to Font constructor parameters#142
Closed
terryspitz wants to merge 3 commits into
Closed
Move tangent/knot visibility to Font constructor parameters#142terryspitz wants to merge 3 commits into
terryspitz wants to merge 3 commits into
Conversation
These were debug-only controls that are not needed as user-facing axes. - show_knots: conditional rendering removed from Font.charToSvg (always off) - show_tangents: moved to Font constructor optional param (showTangentsOpt) so the Glyphs spline debug view can still enable it programmatically https://claude.ai/code/session_019XXGSjNrx6dXyuSJhoAKeP
tweens-chromium-linux.png: stale baseline (tweens grid no longer has show_knots or show_tangents rows); CI will regenerate it with missing- snapshot policy on next run. tween-show-knots / tween-show-tangents: orphaned — these axes no longer exist so the tweens test will never generate or compare against them. https://claude.ai/code/session_019XXGSjNrx6dXyuSJhoAKeP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor the Font class to accept
showTangentsas a constructor parameter instead of reading it from theAxesconfiguration object. This decouples visualization options from the axes definition and simplifies the API surface.Key Changes
Font.fs:
?showTangentsOptoptional parameter to theFontconstructoraxes.show_tangentswith the localshowTangentsvariableaxes.show_knots(lines 1371–1376 and 1391–1394)Axes.fs:
show_knotsandshow_tangentsfields from theAxesrecord typeApi.fs:
generateSplineDebugSvgFromDefsto passtruefor theshowTangentsparameter when creating Font instances for spline debuggingshow_tangents = truefrom the axes record override (now handled via constructor)show_knots = falseandshow_tangents = falsefrom thefontGuidesaxesshow_tangents = falsefromsolveAltSplinesaxesImplementation Details
The change treats tangent visualization as a Font-level rendering option rather than a global axis setting. This allows different Font instances to have different visualization preferences while sharing the same Axes configuration. Knot visualization has been completely removed from the codebase.
https://claude.ai/code/session_019XXGSjNrx6dXyuSJhoAKeP