Skip to content

Implement tests for the log outputs of liblognorm error and debug callbacks#14

Open
Tiihott wants to merge 10 commits intoteragrep:mainfrom
Tiihott:jna_assert_logging
Open

Implement tests for the log outputs of liblognorm error and debug callbacks#14
Tiihott wants to merge 10 commits intoteragrep:mainfrom
Tiihott:jna_assert_logging

Conversation

@Tiihott
Copy link
Contributor

@Tiihott Tiihott commented Jan 15, 2025

Includes:

  • Asserting the log outputs of liblognorm error and debug callbacks in new tests (issue Implement tests for asserting that the logging from c to java is working properly #11).
  • Moved JNA callback interfaces and implementations to separate files from main JNA interface. It was required for log assertions, and tests indicated that JNA library doesn't require them to be inside main JNA interface.
  • Added mockito and log4j dependencies for asserting callback log outputs during tests.

Not yet implemented:

  • Expanded tests

Also includes commits from PR #3, PR #5, PR #6, PR #8 and PR #13. Rebase may be needed in this PR after they have been merged to main.
New commits are f127195 and later.

@Tiihott Tiihott self-assigned this Jan 15, 2025
@Tiihott Tiihott requested a review from 51-code January 16, 2025 06:35
@Tiihott Tiihott requested a review from 51-code January 17, 2025 08:38
Copy link

@51-code 51-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now!

@kortemik
Copy link
Member

please rebase

@Tiihott Tiihott force-pushed the jna_assert_logging branch from a519ca3 to d362ce9 Compare January 28, 2025 06:43
@Tiihott Tiihott force-pushed the jna_assert_logging branch from d362ce9 to 47461d6 Compare January 28, 2025 08:42
@Tiihott
Copy link
Contributor Author

Tiihott commented Jan 28, 2025

Rebased to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement tests for asserting that the logging from c to java is working properly

5 participants