Skip to content

Conversation

@aktech
Copy link
Member

@aktech aktech commented Oct 16, 2024

This adds test workflow for tfx-bsl.

TODO:

  • Create reusable workflow to extract common stuff form build and test workflow
  • Remove trigger on all "*" branches
  • Add xfail to failing tests
  • Add upload to PyPi and twine check

@aktech aktech marked this pull request as ready for review October 16, 2024 13:44
Copy link
Contributor

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes requested (thanks to the helpful comments here).

Sadly the use of unittest really highlights problems that apache-beam feels as a result of dill unconditionally trying to pickle arbitrary objects. Moving forward we should move away from unittest.TestCase methods for carrying out assertions such as self.assertEqual, as this requires pickling the unittest.TestCase itself - which fails. For now, xfailing makes sense.

aktech and others added 3 commits October 18, 2024 00:11
@peytondmurray peytondmurray self-requested a review October 17, 2024 21:18
Copy link
Contributor

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

@peytondmurray peytondmurray merged commit 59fc9c0 into tensorflow:master Oct 22, 2024
@aktech aktech deleted the test-workflow branch October 22, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants