-
Notifications
You must be signed in to change notification settings - Fork 60
Add testing workflow #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
peytondmurray
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few changes requested (thanks to the helpful comments here).
Sadly the use of unittest really highlights problems that apache-beam feels as a result of dill unconditionally trying to pickle arbitrary objects. Moving forward we should move away from unittest.TestCase methods for carrying out assertions such as self.assertEqual, as this requires pickling the unittest.TestCase itself - which fails. For now, xfailing makes sense.
Co-authored-by: Peyton Murray <peynmurray@gmail.com>
peytondmurray
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🚀
This adds test workflow for tfx-bsl.
TODO: