ci: run integration tests against live Tempo container, remove mocks#123
ci: run integration tests against live Tempo container, remove mocks#123brendanjryan wants to merge 5 commits intomainfrom
Conversation
When chain_id was omitted from tempo(), the challenge's methodDetails lacked a chainId field. The Rust CLI (mpp-rs) strictly requires chainId and rejects challenges without it: 'Malformed payment request: missing chainId'. Both mppx and mpp-rs default to 4217 (mainnet). This makes pympp consistent so servers work out of the box without explicitly passing chain_id.
The DEFAULT_FEE_PAYER_URL (sponsor.moderato.tempo.xyz) was a testnet-only service silently used as fallback when no fee payer was configured. With chain_id now defaulting to mainnet (4217), this would route mainnet transactions to a testnet sponsor. Align with mppx and mpp-rs: require explicit fee payer configuration (either a feePayer account on the method, or a feePayerUrl in methodDetails). Raise a clear error if neither is set.
Add integration job to CI that pulls the Tempo Docker image, starts the devnet + Redis via docker compose, and runs integration tests against the live node — matching the mppx pattern. Replace mock-based charge tests with integration tests: - Add 5 new integration tests (hash replay with/without store, store recording, tx not found, external ID) - Remove 5 mock tests from test_tempo.py now covered by integration - Delete test_stores_redis.py (all tests covered by test_stores_redis_integration.py with real Redis) Keep mock tests for error paths (expiry, payload validation, unknown credential type) and transport/protocol tests.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 21eab7c5ad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| run: docker compose up -d --wait | ||
|
|
||
| - name: Run integration tests | ||
| run: uv run pytest -m integration -v --timeout=120 |
There was a problem hiding this comment.
The integration workflow now executes pytest -m integration, but tests/test_stores_redis_integration.py uses the redis marker (not integration), and this commit also deletes tests/test_stores_redis.py. That leaves RedisStore behavior untested in CI (test skips without REDIS_URL, integration excludes non-integration markers), so Redis regressions can merge without detection.
Useful? React with 👍 / 👎.
| account: TempoAccount | None = None, | ||
| fee_payer: TempoAccount | None = None, | ||
| chain_id: int | None = None, | ||
| chain_id: int = CHAIN_ID, |
There was a problem hiding this comment.
Defaulting tempo() to chain_id=4217 makes calls like tempo(rpc_url="...", intents=...) implicitly mainnet-bound. That default is propagated into request methodDetails.chainId and client chain-ID validation, so custom/devnet RPC endpoints on non-4217 chains now fail unless callers add an explicit chain_id, which is a regression from the previous None default behavior.
Useful? React with 👍 / 👎.
1 participant
Summary
Run integration tests against a real Tempo devnet + Redis in CI — matching the mppx pattern. Replace mock-based charge tests with integration tests.
CI Changes
integrationjob that pulls/cachesghcr.io/tempoxyz/tempo:latest, starts devnet + Redis viadocker compose up -d --wait, runspytest -m integrationwithTEMPO_RPC_URLandREDIS_URLci-gaterequired jobsTests Added (integration)
test_verify_hash_replay_rejected_with_storetest_verify_hash_replay_allowed_without_storetest_verify_hash_store_records_on_successtest_verify_hash_tx_not_foundtest_verify_external_id_propagatedTests Removed (mocks)
test_tempo.py(now covered by integration)test_stores_redis.pyentirely (all 8 tests covered bytest_stores_redis_integration.py)Tests Kept (mocks correct)
Expiry validation, payload validation, unknown credential type, transport/protocol tests, access key signing, MCP client mocks.