[DT-3584] Migrate Nexus form to Superforms with validation #3158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace writable store pattern with Superforms - Add Zod schema for form validation - Fix error display: only show after user interaction - Remove `endpointForm` store export - Use bind:this pattern to expose form methods - Update parent components to use new API - Ensure errors don't show on initial load or empty state
andrewzamojc
requested review from
GiantRobots
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![temporal-cicd[bot]](https://avatars.githubusercontent.com/in/357945?s=60&v=4){kind=small}
|
|
||
| let formComponent: NexusForm; | ||
|
|
||
| const createDisabled = $derived( |
Contributor
There was a problem hiding this comment.
⚠️ Variable 'formComponent' is used before being assigned.
Contributor
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the Nexus endpoint form to use Superforms with Zod validation, following the established Superforms pattern used throughout the application.
Changes
nexus-form.svelte: Refactored to use Superforms with proper validation
$form,$errors, and$enhancenexus-create-endpoint.svelte & nexus-edit-endpoint.svelte: Updated to work with new Superforms pattern
Page components: Updated to pass data correctly to Superforms-enabled components
Benefits
Testing