Skip to content

Add back banner#3153

Open
laurakwhit wants to merge 2 commits intomainfrom
3150-add-back-banner
Open

Add back banner#3153
laurakwhit wants to merge 2 commits intomainfrom
3150-add-back-banner

Conversation

@laurakwhit
Copy link
Collaborator

Description & motivation 💭

Adds back <Banner /> in layout with text set via TEMPORAL_BANNER_TEXT.

Screenshots (if applicable) 📸

Screenshot 2026-02-11 at 3 54 26 PM Screenshot 2026-02-11 at 3 54 38 PM

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

#3150

Docs

Any docs updates needed?

@laurakwhit laurakwhit requested review from a team and rossedfort as code owners February 11, 2026 23:08
@vercel
Copy link

vercel bot commented Feb 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
holocene Ready Ready Preview, Comment Feb 11, 2026 11:08pm

Request Review

{/snippet}
<UserMenu {logout} />
</TopNavigation>
<Banner
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Alex-Tideman was this intentionally removed? If so, I'll close this PR and update the docs.

@laurakwhit laurakwhit linked an issue Feb 11, 2026 that may be closed by this pull request
id,
message,
dismissable = false,
dismissLabel = translate('common.close'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ Type 'null' is not assignable to type '"activity" | "add-square" | "add" | "apple" | "archives" | "arrow-down" | "arrow-left" | "arrow-up" | "arrow-right" | "ascending" | "astronaut" | "batch-operation" | "book" | ... 129 more ... | "xmark-square"'.

@temporal-cicd
Copy link
Contributor

temporal-cicd bot commented Feb 11, 2026

Warnings
⚠️

📊 Strict Mode: 2 errors in 2 files (0.2% of 1126 total)

src/lib/holocene/banner/banner.svelte (1)
  • L60:4: Type 'null' is not assignable to type '"activity" | "add-square" | "add" | "apple" | "archives" | "arrow-down" | "arrow-left" | "arrow-up" | "arrow-right" | "ascending" | "astronaut" | "batch-operation" | "book" | ... 129 more ... | "xmark-square"'.
src/routes/(app)/+layout.svelte (1)
  • L60:23: Argument of type '(namespace: string) => { namespace: string; onClick: (namespace: string) => void; }' is not assignable to parameter of type '(value: string | null | undefined, index: number, array: (string | null | undefined)[]) => { namespace: string; onClick: (namespace: string) => void; }'.

Generated by 🚫 dangerJS against 4c00658

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Banner doesn't exist

1 participant