[DO_NOT_MERGE] Store worker attributes needed by server to propagate nexus tasks to worker#9231
Open
[DO_NOT_MERGE] Store worker attributes needed by server to propagate nexus tasks to worker#9231
Conversation
rkannan82
changed the title
This was referenced Feb 5, 2026
yycptt
reviewed
Feb 7, 2026
service/history/api/respondworkflowtaskcompleted/workflow_task_completed_handler.go
Outdated
Show resolved
Hide resolved
rkannan82
changed the title
rkannan82
changed the title
rkannan82
force-pushed
the
kannan/activity-cancel/persist-worker-key
branch
2 times, most recently
from
f1e1ee5 to
e795849
Compare
rkannan82
changed the title
rkannan82
force-pushed
the
kannan/activity-cancel/persist-worker-key
branch
from
43ace13 to
2ecbdfd
Compare
yycptt
approved these changes
Feb 12, 2026
Member
yycptt
left a comment
yycptt
left a comment
There was a problem hiding this comment.
LGTM overall. Please land after removing the unnecessary field.
proto/internal/temporal/server/api/persistence/v1/executions.proto
Outdated
Show resolved
Hide resolved
Add workerControlTaskQueue parameter to AddActivityTaskStartedEvent and persist it in ActivityInfo when an activity starts. This enables routing activity cancellation requests to the correct worker's control queue via Nexus. Changes: - Add worker_control_task_queue field to ActivityInfo proto - Update MutableState interface and implementation - Pass workerControlTaskQueue from poll request for regular activities - Pass from RespondWorkflowTaskCompleted request for eager activities - Update all test call sites
…ontrol_task_queue fields
rkannan82
force-pushed
the
kannan/activity-cancel/persist-worker-key
branch
from
bf3c061 to
1218cae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
As part of RecordActivityTaskStarted flow, store worker_control_task_queue for an activity in the mutable state (ActivityInfo).
Main changes:
Why?
To support activity cancellation without activity heartbeat.
Overall flow:
How did you test it?