Workaround for path collision for activity start and operator APIs#235
Closed
Workaround for path collision for activity start and operator APIs#235
Conversation
Member
Author
|
Closing in favor of a better long term solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Added custom routing logic to fix the activity operator command API routes when they collide with standalone activity start.
NOTE: This should be used to patch the currently released APIs for the UI server and is considered a workaround.
Why?
To unblock the current work. A longer term solution will redefine the activity pause APIs.
How did you test it?
@laurakwhit ran it locally.
Potential risks
Starting activities with certain reserved names (e.g. pause) is not possible and may be confusing.