Open
Conversation
carlydf
force-pushed
the
cdf/get-newest-api-versioning-3-commit
branch
from
cf1e238 to
cec4c73
Compare
Member
|
Hrmm, I am wondering if our CI is bad here. There should be a CI check that does a proto regen and confirms |
Member
|
It was disabled during the gogoproto refactor. I noticed it in my last PR and reenabled it: 5a9f019. |
Member
|
Assuming this check does what I think it should be doing. |
Member
|
Not even sure that generator checker would catch the general thing we want to check (generate protos + git diff). Regardless, for this PR, we need to generate the Go code after refreshing protos. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update proto/api commit to latest on the versioning-3 branch and run
make protoTo bring the submodule in sync with the generated code
How did you test it?
Potential risks