Open
Conversation
chore: bump version to 2.0.0-beta.8
Author
|
@MKRhere Hi! I need to configure Postgres schema, please do review Best regards, |
MKRhere
requested changes
Jul 16, 2024
Comment on lines
40
to
+41
| const create = client.schema | ||
| .withSchema(schema) |
Member
There was a problem hiding this comment.
Wouldn't this error when used with anything other than Postgres? Perhaps instead of defaulting to "public", we can call withSchema only if schema is explicitly passed. Then we don't need to worry about Pg/others.
Suggested change
| const create = client.schema | |
| .withSchema(schema) | |
| const create = (schema ? client.withSchema(schema) : client.schema) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feature: added config pg schema
chore: bump version to 2.0.0-beta.8