[release-v0.39] chore(deps): bump tektoncd/pipeline to v1.6.2#2729
Conversation
Addresses CVE-2026-40161 (GHSA-wjxp-xrpv-xpff), a high-severity vulnerability where the git resolver API mode leaks system-configured API tokens to user-controlled serverURL endpoints. Also includes path traversal hardening for volume mount validation using filepath.Clean. Signed-off-by: Akshay Pant <akpant@redhat.com>
There was a problem hiding this comment.
Code Review
This pull request updates the Go version and the github.com/tektoncd/pipeline dependency. Feedback was provided regarding a likely typo in the Go version directive and the removal of the toolchain specification. Additionally, the reviewer noted that the path traversal hardening mentioned in the PR description is missing from the actual code changes.
| go 1.24.0 | ||
|
|
||
| toolchain go1.24.2 | ||
| go 1.24.13 |
There was a problem hiding this comment.
The go directive version 1.24.13 appears to be a typo, as it is an unusually high patch version for Go 1.24. Additionally, the removal of the toolchain directive reduces control over the specific Go version used for builds. It is recommended to use the minor version in the go directive and specify the patch version in the toolchain directive.
go 1.24
toolchain go1.24.2
There was a problem hiding this comment.
This was automatically updated after running the go mod tidy command. The same version is used by tektoncd/pipeline Ref.
| github.com/spf13/cobra v1.10.1 | ||
| github.com/stretchr/testify v1.11.1 | ||
| github.com/tektoncd/pipeline v1.4.0 | ||
| github.com/tektoncd/pipeline v1.6.2 |
There was a problem hiding this comment.
The pull request description states that this change includes path traversal hardening for volume mount validation using filepath.Clean. However, the current diff only contains changes to go.mod and go.sum. Please include the missing implementation for the hardening logic to ensure the security improvements are applied as intended.
There was a problem hiding this comment.
The fix comes from the dependency update.
54cb7bf
into
tektoncd:release-v0.39.6
📝 Description of the Change
Addresses CVE-2026-40161 (GHSA-wjxp-xrpv-xpff), a high-severity vulnerability where the git resolver API mode leaks system-configured API tokens to user-controlled serverURL endpoints. Also includes path traversal hardening for volume mount validation using filepath.Clean.
🔗 Linked GitHub Issue
Fixes #
🧪 Testing Strategy
🤖 AI Assistance
AI assistance can be used for various tasks, such as code generation,
documentation, or testing.
Please indicate whether you have used AI assistance
for this PR and provide details if applicable.
Important
Slop will be simply rejected, if you are using AI assistance you need to make sure you
understand the code generated and that it meets the project's standards. you
need at least know how to run the code and deploy it (if needed). See
startpaac to make it easy
to deploy and test your code changes.
If the majority of the code in this PR was generated by an AI, please add a
Co-authored-bytrailer to your commit message.For example:
Co-authored-by: Claude noreply@anthropic.com
✅ Submitter Checklist
fix:,feat:) matches the "Type of Change" I selected above.make testandmake lintlocally to check for and fix anyissues. For an efficient workflow, I have considered installing
pre-commit and running
pre-commit installtoautomate these checks.