fix: label values sanitization and normalization

[filariow]

📝 Description of the Change

Label values need to respect strict rules.

Valid label value:

• must be 63 characters or less (can be empty),
• unless empty, must begin and end with an alphanumeric character ([a-z0-9A-Z]),
• could contain dashes (-), underscores (_), dots (.), and alphanumerics between.

This contribution ensures that Label Values are sanitized and normalized to respect the rules above.

🔗 Linked GitHub Issue

N/A

🧪 Testing Strategy

• Unit tests
• Integration tests
• End-to-end tests
• Manual testing
• Not Applicable

🤖 AI Assistance

AI assistance can be used for various tasks, such as code generation,
documentation, or testing.

Please indicate whether you have used AI assistance
for this PR and provide details if applicable.

• I have not used any AI assistance for this PR.
• I have used AI assistance for this PR.

To help me navigate the codebase, as I'm mostly new to it, and to review the changes before submitting them.
The changes and tests were hand-written.

✅ Submitter Checklist

• 📝 My commit messages are clear, informative, and follow the project's How to write a git commit message guide. The Gitlint linter ensures in CI it's properly validated
• ✨ I have ensured my commit message prefix (e.g., fix:, feat:) matches the "Type of Change" I selected above.
• ♽ I have run make test and make lint locally to check for and fix any
  issues. For an efficient workflow, I have considered installing
  pre-commit and running pre-commit install to
  automate these checks.
• 📖 I have added or updated documentation for any user-facing changes.
• 🧪 I have added sufficient unit tests for my code changes.
• 🎁 I have added end-to-end tests where feasible. See README for more details.
• 🔎 I have addressed any CI test flakiness or provided a clear reason to bypass it.
• If adding a provider feature, I have filled in the following and updated the provider documentation:
  • GitHub App
  • GitHub Webhook
  • Gitea/Forgejo
  • GitLab
  • Bitbucket Cloud
  • Bitbucket Data Center

Signed-off-by: Francesco Ilario filario@redhat.com

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: filariow / name: Francesco Ilario (d2a9f42)

[zakisk]

/ok-to-test

[zakisk]

@filariow you need to sign easycla

[gemini-code-assist]

Code Review

This pull request updates the CleanValueKubernetes function to include periods in the character trimming set and adds relevant test cases to verify this behavior. The reviewer identified a potential issue regarding the order of operations, noting that performing trimming before character replacement may lead to invalid Kubernetes label formats. They suggested reordering the logic to perform replacements first, followed by trimming and length validation, and provided a code snippet to implement this improvement.

[zakisk]

/ok-to-test

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.36%. Comparing base (c615efb) to head (3c0e429).
⚠️ Report is 2 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2724      +/-   ##
==========================================
+ Coverage   59.25%   59.36%   +0.10%     
==========================================
  Files         208      208              
  Lines       20573    20626      +53     
==========================================
+ Hits        12191    12244      +53     
  Misses       7610     7610              
  Partials      772      772              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[mathur07]

/retest

[zakisk]

/ok-to-test

[zakisk]

/lgtm

[pipelines-as-code]

Congrats @filariow your PR Has been approved 🎉

✅ Pull Request Approved

Approval Status:

• Required Approvals: 1
• Current Approvals: 1

👥 Reviewers Who Approved:

Reviewer	Permission Level	Approval Status
@zakisk	write	✅

📝 Next Steps

• Ensure all required checks pass
• Comply with branch protection rules
• Request a maintainer to merge using the /merge command (or merge it
  directly if you have repository permission).

Automated by the PAC Boussole 🧭

[zakisk]

@filariow Thank you for your contribution! 🎉