Skip to content

Conversation

@MichaelSun90
Copy link
Contributor

We have serverName in connection configuration, but the logic for actually using it config the cn name is missing. This PR added the logic. #1388

@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.41%. Comparing base (5015634) to head (838a8c1).
⚠️ Report is 84 commits behind head on master.

Files with missing lines Patch % Lines
src/connection.ts 0.00% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1476      +/-   ##
==========================================
- Coverage   80.50%   80.41%   -0.10%     
==========================================
  Files          91       91              
  Lines        4669     4673       +4     
  Branches      856      858       +2     
==========================================
- Hits         3759     3758       -1     
- Misses        634      637       +3     
- Partials      276      278       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

*
* (no default)
*/
serverName?: string;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit: Use servername instead, that would match the option name used by Node.js.

@MichaelSun90
Copy link
Contributor Author

Hi @arthurschreiber , Just checked with David, for JDBC, then actually accept what user provided server name as a higher priority choice compare to server name from the routing. There also some other driver that will try to connect with both and connection with whichever connected successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants