Error output from child processes coloured in red#128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Colour any
stderroutput from a child process in red.The tricky thing to get right was curl; it writes its progress meter to stderr, which was a surprise!
We go to the trouble of
poll()ing both file descriptors so that interleavedstdoutandstderroutput should be captured in the order it was emitted.Finally, we have unified the impact of failed substeps on parent steps (and failed steps on parent procedures, etc) so that the behaviour is the same in both interactive and automatic modes: failure propagates up, but if running interactively the user can "override" what would otherwise be determined to be a failed step and mark it as
Doneinstead.