Adding lifecycle hooks to deis-controller api#3
Merged
Cryptophobia merged 7 commits intomasterfrom Nov 13, 2017
Merged
Conversation
Fix spacing
Member
Author
|
This PR is related to this upstream PR: |
duanhongyi
added a commit
to duanhongyi/controller
that referenced
this pull request
Jan 3, 2021
…o-1.11.23 chore(deps): bump django from 1.11.22 to 1.11.23 in /rootfs
Cryptophobia
added a commit
that referenced
this pull request
Feb 13, 2022
…2.2.27 chore(deps): bump django from 2.2.25 to 2.2.27 in /rootfs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the lifecycle hooks feature to the deis-controller api. This allows users to attach lifecycle postStart and preStop hook commands to kubernetes api via the deis api.
Example of a preStop hook that would gracefully shutdown Resque worker processes:
https://gist.github.com/Cryptophobia/447ecea7858d26141359b22161e70ee2
Example of the POST to
deis.$hostname/v2/apps/testing-again/config:JSON Body:
For long running preStop hooks the
terminationGracePeriodSecondsneeds to be increased for the worker pods:The tests are not written yet.
Code in deis-cli has not been written yet.