Adding procfile_structure on app api#2
Merged
Cryptophobia merged 5 commits intomasterfrom Nov 13, 2017
Merged
Conversation
Member
Author
|
This PR is related to this upstream PR: |
a38bb88 to
ae3740f
Compare
tmedford
approved these changes
Nov 13, 2017
Cryptophobia
added a commit
that referenced
this pull request
Oct 1, 2020
chore(controller): permit umbrella override api group #2
duanhongyi
added a commit
to duanhongyi/controller
that referenced
this pull request
Jan 3, 2021
…o-1.11.22 chore(deps): bump django from 1.11.21 to 1.11.22 in /rootfs
Cryptophobia
added a commit
that referenced
this pull request
Feb 13, 2022
…2.2.25 chore(deps): bump django from 2.2.24 to 2.2.25 in /rootfs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
/approute should expose the procfile_structure of the app release. Since the structure on the/approute is not indicative of the actual deployable processes of the application, there should be another json structure that can tell us what the procfile is actually set to for the latest release. When usingprocfile_structurewe can tell which of the processes exist in our procfile at this particular release:The idea is that we can use
procfile_structurefor scaling and validating which processes we can actually scale through the/scaleroute. This is so because a call to.../app/{app_name}/scalewith a payload{"worker": 1}would actually fail with404 Not Foundand this return from the api:Our app structure is below:
But a call for each of the processes in procfile_structure would not fail the scale call.
This has been tested extensively with git remote application deployments and Docker image pull deployments.
The tests are not written yet.
Code in deis-cli has not been written yet.