[WIP] Update configurable WebSocket buffer sizes for Nostr events #507
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plan to Fix Test Assertion Handling in StandardWebSocketClientMultiMessageTest
This PR addresses the feedback that test assertions running in background threads are not properly surfaced to JUnit.
Changes Needed
testAccumulatesMessagesUntilEoseto capture exceptions from worker threadtestCompletesImmediatelyOnOkto capture exceptions from worker threadtestEventWithoutEoseTimesOutto capture exceptions from worker threadAtomicReference<Throwable>Approach
Instead of throwing RuntimeException in the worker threads, we'll:
AtomicReference<Throwable>to capture any exceptions from the worker threadjoin(), check if an exception was captured and rethrow it in the main threadThis ensures that if
send()blocks indefinitely, times out unexpectedly, or returns incorrect results, the test will properly fail.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.