Open
Conversation
added 2 commits
February 5, 2026 14:06
- Cache simple set - Base set card length on files not expand whole set - Only call git log once for last edits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to improve to compile times on the current build system by a large amount.
Afaik there is rewrite in progress, but this could still help devs in the meantime.
It might also improve the CI compile times.
Changes
git logonce to fill last edits cachesetToSetSimplegetCardsLengthtocardUtil, which gets cardcount by filesystemsetToSetSimplenow usesgetCardsLengthto get card count, instead of expanding whole cardset just to get the numberDetails
Currently the compile can take up to 25 minutes, depending on the setup.
The changes in this PR bring it down to 30-40 seconds.
setToSetSimplecalledgetCardsjust to get the card count. This process can take many seconds.setToSetSimplebecause it is called for each processed card, while it is only needed to be done once. Which reduces the time more, even after optimizations