Merged
Conversation
…180 to 0_360) to consider the cell on prime meridian (or indeed any cell at least somewhat on the right of it) to be part of the right hand raster, not the left hand. This is because our ERA5 grid extent is -.125 to 359.875, rather than .125 to 360.125. We don't want to duplicate the column on the prime meridian.
…eted process of documenting how user level data is created from raw data in data-raw.
…) seems to not be compatible with spatRasters (they require external pointers).
… changed the name of as.data.table.raster.terra to avoid it being recognized as an S3 method.
…ts during the weights tolerance join.
…of the climate data (only converted into 0-360 coordinate system if climate data is in 0-360)
modify secondary_weights function output to match coord system of climate data
37 weird cell widths
…inates. Can explain further why we made this choice if needed.
Remove rotate from staggregate
…the rotation is performed or not.
42 remove na option
…d secondary raster check for standad/climate coordinates
…into terra_conversion
…th code chunks that use terra::rotate()
… -- still need to do checks on how define res checks
…into terra_conversion
cullen-molitor
requested changes
Apr 16, 2025
Collaborator
cullen-molitor
left a comment
cullen-molitor
left a comment
There was a problem hiding this comment.
There are several items which require additional fixes or checks before merging. Overall, many of the changes look good, though some portions of the staggregate.R file seem complex and could probably use refactoring in later versions.
Collaborator
cullen-molitor
left a comment
cullen-molitor
left a comment
There was a problem hiding this comment.
Looks good to me!
cullen-molitor
approved these changes
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not to be merged yet - using for diff comparison