Skip to content
This repository was archived by the owner on Sep 9, 2024. It is now read-only.
/ react-native-picker-module Public archive

feat: add better typing for items and onValueChange #55

Open
jekel1818 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add better typing for items and onValueChange #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions react-native-picker-module.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ declare module "react-native-picker-module" {
hide: () => void,
}

export type Item = number | string | { label: string; value: number | string }
Copy link
Author

@jekel1818 jekel1818 Mar 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the android code, I think items could have a more specific type than any

        if (mDataset.getType(position) == ReadableType.Map) {
            if (mDataset.getMap(position).getType("value") != ReadableType.Null) {
                if (mDataset.getMap(position).getType("value") == ReadableType.String) {
                    value = mDataset.getMap(position).getString("value");
                } else {
                    double number = mDataset.getMap(position).getDouble("value");
                    if (number == Math.rint(number)) {
                        value = String.valueOf((int) number);
                    } else {
                        value = String.valueOf(number);
                    }
                }
                if (mDataset.getMap(position).getType("label") == ReadableType.String) {
                    text = mDataset.getMap(position).getString("label");
                } else {
                    double number = mDataset.getMap(position).getDouble("label");
                    if (number == Math.rint(number)) {
                        text = String.valueOf((int) number);
                    } else {
                        text = String.valueOf(number);
                    }
                }
            }
        } else if (mDataset.getType(position) == ReadableType.String) {
            text = mDataset.getString(position);
            value = mDataset.getString(position);
        } else if (mDataset.getType(position) == ReadableType.Number) {
            double number = mDataset.getDouble(position);
            if (number == Math.rint(number)) {
                text = String.valueOf((int) number);
                value = String.valueOf((int) number);
            } else {
                text = String.valueOf(number);
                value = String.valueOf(number);
            }
        }


export interface ReactNativePickerModuleProps {
/**
* Initial value of picker
Expand All @@ -30,7 +32,7 @@ declare module "react-native-picker-module" {
* Items of picker
* @default []
*/
items: any[]
items: Item[]
/**
* Title of picker
* @default undefined
Expand All @@ -45,7 +47,7 @@ declare module "react-native-picker-module" {
* Callback function run after value changed
* @param value
*/
onValueChange: (value: any) => void
onValueChange: (value: string) => void
Copy link
Author

@jekel1818 jekel1818 Mar 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the android code, I think the only possible value is a string

final String finalValue = value;
...
callback.invoke(finalValue);

/**
* Callback function run after cancel
*/
Expand Down