Edit regular expression in charge of removing anchor, simply add 'colon'#72
Open
ABrisset wants to merge 1 commit into
Open
Edit regular expression in charge of removing anchor, simply add 'colon'#72ABrisset wants to merge 1 commit into
ABrisset wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that urls containing anchors like "#sku:123" (e.g a semi-colon) were not cleaned up when passed to the
to_absolutemethod . As a consequence, they were escaped and added to the queue of the crawler, which led to 404 errors. This kind of bug is related to the issue I described here.To fix it, this commit adds a colon in the regular expression used to remove anchor from urls in the
to_absolutemethod.