Skip to content

[WIP] Plugins architecture proposal#46

Open
taganaka wants to merge 10 commits into
masterfrom
plugins
Open

[WIP] Plugins architecture proposal#46
taganaka wants to merge 10 commits into
masterfrom
plugins

Conversation

@taganaka

Copy link
Copy Markdown
Owner

No description provided.

@taganaka

Copy link
Copy Markdown
Owner Author

cc @tmaier

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.62%) when pulling 02ee484 on plugins into 0e4b19a on master.

@taganaka

Copy link
Copy Markdown
Owner Author

API Proposal:

Polipus.crawler(name, starting_urls, options) do |crawler|
  crawler.register_plugin(Class::Name, plugin_options)
end

@tmaier

tmaier commented Jun 30, 2014

Copy link
Copy Markdown
Contributor
  1. Shall a plugin be able to be registered more than once?
  2. Shall it be possible to unregister a plugin again?
    This way, we could register some default plugins. If someone does not like them, they can unregister them by themself.
    This would also be necessary to stay backwards compatible: We automatically register the plugins resulting from the old options. And give a deprecation warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants