Add unicast receive capability. Add MacOS support. Make both Linux & MacOS work.#34
Open
sbytnar wants to merge 1 commit intotabacha:masterfrom
Open
Add unicast receive capability. Add MacOS support. Make both Linux & MacOS work.#34sbytnar wants to merge 1 commit intotabacha:masterfrom
sbytnar wants to merge 1 commit intotabacha:masterfrom
Conversation
…MacOS work (thanks to netifaces.) Update README
Contributor
|
Thanks @sbytnar for providing this MR. I've merged it to master at https://github.com/Z3po/ProSafeLinux . Feel free to check there for updates which (hopefully) come available soon :) @tabacha if you'd like you could point to my repository as you do not want to maintain this anymore. I'll be happy to take over. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works for me. :-)
Verified "discover" and "query" on MacOS & Raspbian. Made some notes in Known issues about inconsistent behavior.
Did not verify "set".
Some changes to README to describe the project better.
Q: Is socket.SO_REUSEPORT really necessary? A: I enabled it in earlier passes to get earlier MacOS changes working, and left it in when I found it worked on Linux & MacOS. Doesn't hurt?
The unicast changes may address: #33 (comment)