Allow (Domain-) Admins to delete aliases #873
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t2d
force-pushed
the
admin-delete-alias
branch
from
0b09a08 to
68a1088
Compare
t2d
requested review from
0x46616c6b,
doobry-systemli and
y3n4
as code owners
|
0x46616c6b
reviewed
Sep 6, 2025
| && $isNotDeleted | ||
| && $isRandom | ||
| && $isOwner; | ||
| $alias = $subject; // already ensured to be Alias by supports() |
Member
There was a problem hiding this comment.
SonarCloud complains when a method has more than three return statements...
Contributor
Author
There was a problem hiding this comment.
If I try to refactor it with 3 or less, it only get's worse. Do you have a good idea?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Admin:
User:
