docs: add concurrency guidance and lock contention warnings to skills#1156
Merged
docs: add concurrency guidance and lock contention warnings to skills#1156
Conversation
The swamp-model skill now prompts users with a design checkpoint before model creation — asking whether methods will run concurrently or be long-running, and guiding them to the factory pattern if so. The factory pattern description is updated to call out both data reuse and concurrency as motivations. The workflow data-chaining reference now warns that steps on the same model serialize on the per-model lock. Closes swamp.club/lab#43 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
Blocking Issues
None.
Suggestions
- SKILL.md exceeds 500-line limit —
.claude/skills/swamp-model/SKILL.mdis already 539 lines onmain, and this PR adds ~18 net lines (bringing it to ~557). CLAUDE.md requires keeping SKILL.md under 500 lines, splitting detailed content intoreferences/files. The new "Design check" section (16 lines) is a good candidate to move into a reference file (e.g.,references/concurrency-design.md) with a one-line pointer from SKILL.md. This is a pre-existing violation so it shouldn't block this PR, but worth addressing in a follow-up.
Notes
- Content is technically accurate: the per-model exclusive lock behavior and factory pattern guidance for parallelism are correct and address a real user pain point (swamp.club/lab#43).
- The lock contention warning in
data-chaining.mdis a valuable addition — the previous text ("Steps within a job run in parallel") was misleading without the serialization caveat. - No code changes, so no test/type-check/lint concerns.
- No security issues.
- No libswamp import boundary concerns (documentation-only change).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses swamp.club/lab#43 — users hitting model locks during long-running operations because they didn't know to split concerns into separate model instances.
Test plan
deno fmt --checkpassesdeno lintpassesdeno run testpasses (4280 tests)🤖 Generated with Claude Code