Skip to content

chore: regenerate models from upstream schemas#66

Open
stack72 wants to merge 1 commit intomainfrom
automated/regenerate-models
Open

chore: regenerate models from upstream schemas#66
stack72 wants to merge 1 commit intomainfrom
automated/regenerate-models

Conversation

@stack72
Copy link
Copy Markdown
Contributor

@stack72 stack72 commented Apr 12, 2026

Summary

Automated regeneration of extension models from upstream provider schemas.

Changes

  • gcp: 25 files changed

Schema Sources

  • AWS: CloudFormation Resource Schema
  • GCP: Google Discovery Documents
  • Hetzner: Hetzner Cloud OpenAPI spec
  • DigitalOcean: DigitalOcean OpenAPI spec

Review Notes

  • Files under model/ are auto-generated — review the manifest.yaml diffs for version changes
  • CalVer versioning with content-based change detection ensures versions only bump when content changes
  • Publishing happens automatically when this PR is merged (via the publish workflow)

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Blocking Issues

  1. Model files changed without corresponding codegen/ changes. All 25 changed files are under model/gcp/, and the diff contains substantial content changes beyond version/upgrade entries (new schema fields added in ces/apps.ts, compute/urlmaps.ts, ces/apps_versions.ts; fields removed in bigquerydatapolicy/datapolicies.ts; description text updated across beyondcorp files). Per CLAUDE.md and the review policy, model files are auto-generated and must never be hand-edited. The two permitted cases for model-only changes are (a) codegen pipeline modification (requires codegen/ to also change) and (b) version-only bumps via the bump-versions script (only version, upgrades, and manifest entries change). This PR fits neither case.

    If these changes were produced by running deno task generate:gcp against updated upstream Google Discovery Documents — which the PR title strongly implies — please confirm by either:

    • Adding a brief note in the PR body confirming the exact codegen command run and that the output was not manually modified, or
    • Verifying the output is reproducible: run deno task generate:gcp a second time from codegen/ and confirm there are zero new diffs.

    If the codegen pipeline itself was modified as part of this work, those codegen/ changes must be included in this PR.

Suggestions

  1. Misleading upgrade descriptions for additive changes. ces/apps.ts, ces/apps_tools.ts, ces/apps_versions.ts, and compute/urlmaps.ts / regionurlmaps.ts all add significant new optional fields but their upgrade entry reads "No schema changes". Functionally this is safe (optional fields don't require data migration), but the description is inaccurate. If the codegen always emits "No schema changes" for additive-only updates, this is a pre-existing codegen behaviour and not a blocker for this PR — but worth revisiting in the pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant