Conversation
There was a problem hiding this comment.
Code Review
Blocking Issues
-
Model files changed without corresponding codegen/ changes. All 25 changed files are under
model/gcp/, and the diff contains substantial content changes beyond version/upgrade entries (new schema fields added inces/apps.ts,compute/urlmaps.ts,ces/apps_versions.ts; fields removed inbigquerydatapolicy/datapolicies.ts; description text updated acrossbeyondcorpfiles). Per CLAUDE.md and the review policy, model files are auto-generated and must never be hand-edited. The two permitted cases for model-only changes are (a) codegen pipeline modification (requirescodegen/to also change) and (b) version-only bumps via thebump-versionsscript (onlyversion,upgrades, andmanifestentries change). This PR fits neither case.If these changes were produced by running
deno task generate:gcpagainst updated upstream Google Discovery Documents — which the PR title strongly implies — please confirm by either:- Adding a brief note in the PR body confirming the exact codegen command run and that the output was not manually modified, or
- Verifying the output is reproducible: run
deno task generate:gcpa second time fromcodegen/and confirm there are zero new diffs.
If the codegen pipeline itself was modified as part of this work, those
codegen/changes must be included in this PR.
Suggestions
- Misleading upgrade descriptions for additive changes.
ces/apps.ts,ces/apps_tools.ts,ces/apps_versions.ts, andcompute/urlmaps.ts/regionurlmaps.tsall add significant new optional fields but their upgrade entry reads"No schema changes". Functionally this is safe (optional fields don't require data migration), but the description is inaccurate. If the codegen always emits"No schema changes"for additive-only updates, this is a pre-existing codegen behaviour and not a blocker for this PR — but worth revisiting in the pipeline.
Summary
Automated regeneration of extension models from upstream provider schemas.
Changes
Schema Sources
Review Notes
model/are auto-generated — review themanifest.yamldiffs for version changes