chore: regenerate models from upstream schemas#62
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
Blocking Issues
None.
Observations
All 28 changed files are auto-generated files under model/ with proper auto-generation headers. This is a legitimate automated regeneration from upstream provider schema changes (AWS CloudFormation + GCP Discovery Documents). No codegen/ pipeline changes are expected since only upstream schemas changed, not the pipeline itself.
Changes verified:
- AWS:
appintegrations/application— Description made optional, newApplicationTypeenum field added;connectcampaignsv2/campaign— newEntryLimitsConfigadded;lambda/function— EFS ARN regex extended to support S3 file system ARNs - GCP:
agentregistry/bindings— new model file added following standard generated pattern;bigquerydatapolicy/datapolicies— newdataGovernanceTagfield;dataflow/jobs— newlatencyTierfield, deprecation notices updated;drive/filesandchanges— newclientEncryptionDetailsfield + newgenerate_cse_tokenmethod;firestore— removed upstream-dropped fields (customPartitionFieldPaths,numberSpec);ondemandscanning— removed upstream-droppedaiSkillAnalysisfield; various description-only updates forservicemanagement,hypercomputecluster,developerconnect
All new fields are optional, so no breaking data migration is needed — upgrade entries correctly use passthrough upgradeAttributes.
Suggestions
- Some upgrade entry descriptions say "No schema changes" (e.g., dataflow/jobs adding
latencyTier, developerconnect addinghttpProxyBaseUri) when structural schema changes did occur. The phrasing is accurate in the migration sense (noupgradeAttributeslogic needed), but could be more precise (e.g., "Added optional field: latencyTier") for changelog clarity. Minor — doesn't block merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automated regeneration of extension models from upstream provider schemas.
Changes
Schema Sources
Review Notes
model/are auto-generated — review themanifest.yamldiffs for version changes