Closed
Conversation
as the parsing of the strings goes through Url the output behavior is incorrect when the implicit defaults of `Url` are ignored. for example `wss://nats-server.com:443` would previously lead to the client trying to connect to port `4222`, because `Url::port` returns `None` for this case.
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com> Co-authored-by: Piotr Piotrowski <piotr@synadia.com> Co-authored-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Nick Gerace <nick@systeminit.com>
Signed-off-by: Nick Gerace <nick@systeminit.com>
Signed-off-by: Nick Gerace <nick@systeminit.com>
Signed-off-by: Nick Gerace <nick@systeminit.com>
Signed-off-by: Nick Gerace <nick@systeminit.com>
nickgerace
force-pushed
the
nick/d94750e
branch
from
728f32a to
4561628
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accidental PR: nats-io#1382