Keep streaming Scanner visible alongside text until round closes#2
Merged
Keep streaming Scanner visible alongside text until round closes#2
Conversation
A single round can emit text deltas and then switch to tool_call deltas inside the same assistant message. The previous markup suppressed the Scanner the moment streamingText went truthy, so the bubble looked done responding the instant text stopped flowing - even when the model was still building a tool call on the wire and nothing had arrived in the message list yet. Fix is to render the Scanner unconditionally inside the streaming bubble: below the live Markdown when text is present, on its own when the buffer is still empty. The continuous "still working" cue now spans the entire window from send through the final end-of-stream marker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A single round can emit text deltas and then switch to tool_call
deltas inside the same assistant message. The previous markup
suppressed the Scanner the moment streamingText went truthy, so the
bubble looked done responding the instant text stopped flowing -
even when the model was still building a tool call on the wire and
nothing had arrived in the message list yet.
Fix is to render the Scanner unconditionally inside the streaming
bubble: below the live Markdown when text is present, on its own
when the buffer is still empty. The continuous "still working" cue
now spans the entire window from send through the final
end-of-stream marker.