pat-familytree changes #1
Draft
+13,732
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this fix the y-position was calculated incorrectly for scales below 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for the integration into https://github.com/Patternslib/pat-family-tree
Note:
For the change "fix: view-handlers cardToMiddle. Fix calculation of cardToMiddle." there is a separate pull request: fix: Fix calculation of cardToMiddle. donatso/family-chart#86
This one is needed for doing a correct layout of the cards.
Probably the change "Fix for missing parents in main element." isn't needed - I can't reproduce the problem it's trying to solve. We might want to only use that change if we run into problems.
This is the branch with other experiments, like "Don't zoom on double click" and "Pass 'main' to setupSiblings" which we used during trying out ways to set a card as main card with siblings in the middle of the tree - but we came up with a different solution (tree + reversed tree for parents, as foreseen by family-chart). This branch is based on family-chart v0.9
https://github.com/syslabcom/family-chart/tree/setup-siblings-v9
The same like 3) but different commit ordering and based on family-chart v0.8 and currently used in production. https://github.com/syslabcom/family-chart/tree/setup-siblings
NOTE:
is based on family-chart v0.8 and compatible with pat-family-tree 0.0.1-alpha.18.