Rebuild dimmers on monitor hotplug (1.0.1)#3
Merged
Conversation
The daemon's dimmer set was a one-shot snapshot of gdk::Display::default().monitors() taken in build_app. On a multi-GPU rig where the primary briefly attaches to a passthrough HDMI during boot before switching to DP on the main GPU, the snapshot misses the real primary and the daemon never builds a dimmer for it — leaving primary bright after the switch while the secondaries dim correctly. Split App.surfaces into menu_window + Rc<RefCell<Vec<Window>>> dimmers so the dimmer set can be replaced without rebuilding the menu (which owns the WebKitGTK process daemon mode keeps alive across hide/show). window::watch_monitor_changes connects items-changed on the GDK monitor list and destroys + rebuilds the dimmer windows on every delta, presenting them immediately if the menu is open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
App.surfacesintomenu_window+Rc<RefCell<Vec<Window>>>dimmers so the dimmer set is mutable.window::watch_monitor_changesconnectsitems-changedongdk::Display::default().monitors(), destroys old dimmer windows on every delta, builds fresh ones for every currently-connected monitor, and presents them immediately if the menu is open.1.0.0→1.0.1(patch: bugfix, no API or config changes).Test plan
cargo test— 3/3 passcargo build— cleanbuild (release)greenitems-changed, trigger glogout, confirm all monitors dim