Updated Getting Started UG documentation for Blazor components#8028
Updated Getting Started UG documentation for Blazor components#8028Backiaraj wants to merge 2 commits intodevelopmentfrom
Conversation
|
Build Status: INQUEUE 🕒 |
|
Build Status: INPROGRESS 🔃 |
|
CI Status: SUCCESS ✅ |
There was a problem hiding this comment.
📋 Review Summary
Overall Quality: Needs Work
Target .NET Version: .NET 10 (based on aspnetcore-10.0 references)
📊 Findings Overview
⚠️ 2 Major issues- ℹ️ 8 Minor issues
❌ Changes Requested
The PR simplifies the Getting Started documentation structure, which is a positive improvement. However, there is one critical issue that must be addressed:
Major Issues:
- blazor/badge/getting-started-with-web-app.md (line 110): The note about Global interactivity location needs clearer explanation about when developers need to take action.
- blazor/breadcrumb/getting-started-with-web-app.md (line 133): The note about dual service registration for WebAssembly/Auto modes needs to be more explicit that BOTH projects require registration.
Minor Issues:
- Multiple grammatical errors: "at top of" should be "at the top of" (appears in multiple files)
- Formatting inconsistencies with code block spacing
- Inconsistent use of "e.g." vs "For example"
- Code highlighting (hl_lines) may not match simplified code snippets
- Some notes could be clearer about actionable guidance
🎯 Positive Changes:
The PR successfully simplifies the documentation by:
- Consolidating NuGet installation instructions outside tab sections
- Removing redundant images and verbose explanations
- Updating theme references from bootstrap5 to fluent2
- Standardizing wording across similar documents
- Removing version-specific Visual Studio references
Please review the inline comments for detailed recommendations on each issue.
🤖 Automated review by Blazor Docs PR Reviewer Agent
| Add the Syncfusion<sup style="font-size:70%">®</sup> Blazor Breadcrumb component in the **~/Components/Pages/*.razor** file. If the interactivity location is set to `Per page/component` in the Web App, define a render mode at top of the `~Pages/*.razor` file. (e.g. `InteractiveServer`, `InteractiveWebAssembly` or `InteractiveAuto`). | ||
|
|
||
| N> If an **Interactivity Location** is set to `Global` and the **Render Mode** is set to `Auto` or `WebAssembly`, the render mode is configured in the `App.razor` file by default. | ||
| N> If an **Interactivity Location** is set to `Global` with `Auto` or `WebAssembly`, the render mode is configured in the `App.razor` file by default. |
There was a problem hiding this comment.
Content Clarity (Minor)
The note should clarify what "configured in the App.razor file by default" means for developers.
Recommended fix:
N> If an **Interactivity Location** is set to `Global` with `Auto` or `WebAssembly`, you don't need to specify a render mode in individual components because the render mode is already configured globally in the `App.razor` file.This makes the guidance more actionable and clear.
|
|
||
| {% endhighlight %} | ||
| {% endtabs %} | ||
|
|
There was a problem hiding this comment.
Consistency Issue (Minor)
In the WASM documentation, you're using simplified code snippets with "....", but the highlighting still references line numbers (hl_lines="2 4"). This may not accurately reflect the condensed code structure.
Recommended fix: Either remove the hl_lines parameter for simplified snippets or provide a complete code block. For consistency with the new simplified approach:
{% highlight C# tabtitle="Program.cs" %}
using Syncfusion.Blazor;
// ... other code ...
builder.Services.AddSyncfusionBlazor();
// ... other code ...
{% endhighlight %}Or simply remove highlighting from simplified examples.
|
|
||
| {% endhighlight %} | ||
| {% endtabs %} | ||
|
|
There was a problem hiding this comment.
Technical Accuracy (Major)
The note says to register Syncfusion service in both server and client projects when using WebAssembly or Auto mode. However, this is incomplete - it should specify that service registration is required in BOTH projects for these modes.
Recommended fix:
N> If the **Interactive Render Mode** is set to `WebAssembly` or `Auto`, you must register the Syncfusion<sup style="font-size:70%">®</sup> Blazor service in the **Program.cs** files of BOTH the server project and the client project (.Client) in the Blazor Web App. This ensures components work correctly in both rendering contexts.This clarification is critical for developers to avoid runtime errors.
|
|
||
| N> If an Interactivity Location is set to `Global` and the **Render Mode** is set to `Server`, the render mode is configured in the `App.razor` file by default. | ||
| N> If an Interactivity Location is set to `Global`, the render mode is already configured in the `App.razor` file by default. | ||
|
|
There was a problem hiding this comment.
Content Clarity (Minor)
The note about Global interactivity could be more specific about the render mode.
Recommended fix:
N> If an Interactivity Location is set to `Global` with the `Server` render mode, you don't need to define a render mode in the component as it's already configured globally in the `App.razor` file.This clarifies that for Server mode specifically, the configuration is already handled globally.
|
|
||
| Add the Syncfusion<sup style="font-size:70%">®</sup> Blazor Breadcrumb component in the **~/Components/Pages/Home.razor** file. If the interactivity location is set to `Per page/component`, define a render mode at the top of the `Home.razor` page. | ||
| Add the Syncfusion<sup style="font-size:70%">®</sup> Blazor Breadcrumb component in the **~/Components/Pages/Home.razor** file. If the interactivity location is set to `Per page/component`, define a render mode at top of the `~Pages/Home.razor` file. | ||
|
|
There was a problem hiding this comment.
Content Clarity (Minor)
The phrase "define a render mode at top of" is missing "the" before "top".
Recommended fix:
Add the Syncfusion<sup style="font-size:70%">®</sup> Blazor Breadcrumb component in the **~/Components/Pages/Home.razor** file. If the interactivity location is set to `Per page/component`, define a render mode at the top of the `~Pages/Home.razor` file.|
|
||
| {% tabs %} | ||
| {% highlight C# tabtitle="Blazor Server App" hl_lines="3 10" %} | ||
| {% highlight C# tabtitle="Program.cs" hl_lines="2 4" %} |
There was a problem hiding this comment.
Content Clarity (Minor)
The highlighting in the code block (hl_lines="2 4") may not accurately reflect the actual line numbers after simplification.
Recommended fix: Verify that the highlighted lines correctly point to the Syncfusion import and service registration lines. Consider using descriptive highlighting:
{% highlight C# tabtitle="Program.cs" hl_lines="2 4" %}
....
using Syncfusion.Blazor; // Line 2: Import namespace
....
builder.Services.AddSyncfusionBlazor(); // Line 4: Register service
....Or adjust the highlighting to match the actual visible lines in the simplified code.
| | Per page/component | Auto | @rendermode InteractiveAuto | | ||
| | | WebAssembly | @rendermode InteractiveWebAssembly | | ||
| | | None | --- | | ||
| Add the Syncfusion<sup style="font-size:70%">®</sup> Blazor Breadcrumb component in the **~/Components/Pages/*.razor** file. If the interactivity location is set to `Per page/component` in the Web App, define a render mode at top of the `~Pages/*.razor` file. (e.g. `InteractiveServer`, `InteractiveWebAssembly` or `InteractiveAuto`). |
There was a problem hiding this comment.
Formatting Issue (Minor)
Similar to Badge component: grammatical error "at top of" should be "at the top of".
Recommended fix:
Add the Syncfusion<sup style="font-size:70%">®</sup> Blazor Breadcrumb component in the **~/Components/Pages/*.razor** file. If the interactivity location is set to `Per page/component` in the Web App, define a render mode at the top of the `~Pages/*.razor` file. (For example, `InteractiveServer`, `InteractiveWebAssembly`, or `InteractiveAuto`).Also consider using "For example" instead of "e.g." for clarity.
|
|
||
| The theme stylesheet can be accessed from NuGet through [Static Web Assets](https://blazor.syncfusion.com/documentation/appearance/themes#static-web-assets). Include the stylesheet reference in the `<head>` section of the **~/index.html** file. | ||
| The theme stylesheet can be accessed from NuGet through [Static Web Assets](https://blazor.syncfusion.com/documentation/appearance/themes#static-web-assets). Include the stylesheet reference in the **~/index.html** file. | ||
|
|
There was a problem hiding this comment.
Formatting Issue (Minor)
Missing space after the closing code block. This affects Markdown rendering.
Recommended fix:
```html
<link href="_content/Syncfusion.Blazor.Themes/fluent2.css" rel="stylesheet" />N> Check out the [Blazor Themes]...
Add a blank line between the code block and the note for proper Markdown formatting.
| The theme stylesheet and script can be accessed from NuGet through [Static Web Assets](https://blazor.syncfusion.com/documentation/appearance/themes#static-web-assets). Include the stylesheet reference in the `<head>` section in the **~/Components/App.razor** file as shown below: | ||
| The theme stylesheet can be accessed from NuGet through [Static Web Assets](https://blazor.syncfusion.com/documentation/appearance/themes#static-web-assets). Include the stylesheet reference in the **~/Components/App.razor** file. | ||
|
|
||
| ```html |
There was a problem hiding this comment.
Content Clarity (Major)
This note statement could be clearer. The phrase "render mode is already configured" might confuse readers about whether they need to take action.
Recommended fix:
N> If an **Interactivity Location** is set to `Global` with `Auto` or `WebAssembly`, you don't need to define a render mode as it's already configured globally in the `App.razor` file.This makes it clearer that no action is needed when using Global interactivity location.
| ## Add stylesheet | ||
|
|
||
| The theme stylesheet and script can be accessed from NuGet through [Static Web Assets](https://blazor.syncfusion.com/documentation/appearance/themes#static-web-assets). Include the stylesheet reference in the `<head>` section in the **~/Components/App.razor** file as shown below: | ||
| The theme stylesheet can be accessed from NuGet through [Static Web Assets](https://blazor.syncfusion.com/documentation/appearance/themes#static-web-assets). Include the stylesheet reference in the **~/Components/App.razor** file. |
There was a problem hiding this comment.
Formatting Issue (Minor)
Minor formatting inconsistency: there's an extra space before the period in "file. (e.g.".
Recommended fix:
Add the Syncfusion<sup style="font-size:70%">®</sup> Blazor Badge component in the **~/Components/Pages/*.razor** file. If an interactivity location is set to `Per page/component` in the Web App, define a render mode at top of the `~Pages/*.razor` file. (e.g. `InteractiveServer`, `InteractiveWebAssembly` or `InteractiveAuto`).Remove the extra space after "file" and consider using "For example" instead of "e.g." for better readability.
Description
Updated Getting Started UG documentation for Blazor components.
Code Studio usage(Mandatory)
Code Studio used in this PR/MR?
If
Yes: Primary use (choose one)Outcome
If “Cost time” explain in short (1 or 2 lines):
Type of Change
Reviewer Checklist (Mandatory)