Migrate config from XML to PHP#140
Merged
Merged
Conversation
fabpot
approved these changes
Nov 29, 2025
Contributor
|
Thank you @qdequippe. |
fabpot
added a commit
that referenced
this pull request
Dec 3, 2025
This PR was merged into the 8.x-dev branch. Discussion ---------- Fix routing and update config After updating a Symfony app to 8.2.0 version of this package, some tests started to fail. It's because of a minor error in the `symfony_connect_failure` route name introduced in #140. I also updated the other config files to use abstract arguments to keep the original XML comments. Commits ------- 13d08e6 Fix routing and update config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As XmlFileLoader is deprecated, this pull request migrates configuration from XML to PHP.