Skip to content

Conversation

@petruki
Copy link
Member

@petruki petruki commented Dec 6, 2025

This pull request introduces several improvements and refactors across the codebase, focusing on modernizing Angular patterns, updating dependencies. The most significant changes include migrating to Angular signals for state management, and refactoring the toast service and related components for better reactivity and compatibility with Zoneless implementation.

Angular Modernization & State Management

  • Migrated various components (AppComponent, AppVersionComponent, and ToastService) from traditional properties and RxJS Subjects to Angular signals for state management, improving reactivity and simplifying change detection. This includes using signal for UI state, replacing @Input with input, and leveraging takeUntilDestroyed for cleanup. ([[1]](https://github.com/switcherapi/switcher-management/pull/444/files#diff-67cc87ff80ea9d72310b26cb3557524719dff5ba1145dd9126cc76fa498db515L1-R2), [[2]](https://github.com/switcherapi/switcher-management/pull/444/files#diff-67cc87ff80ea9d72310b26cb3557524719dff5ba1145dd9126cc76fa498db515L15-L44), [[3]](https://github.com/switcherapi/switcher-management/pull/444/files#diff-884f7f49640e5923f6bcac4c51d90340330a178f662defbe61e5f5aac1c512deL1-R5), [[4]](https://github.com/switcherapi/switcher-management/pull/444/files#diff-884f7f49640e5923f6bcac4c51d90340330a178f662defbe61e5f5aac1c512deL15-R48), [[5]](https://github.com/switcherapi/switcher-management/pull/444/files#diff-fc887150a340b06c50cf05d5c9939b530ed3cc2ed8e71162c2264194a3b4c76aL1-R14), [[6]](https://github.com/switcherapi/switcher-management/pull/444/files#diff-fc887150a340b06c50cf05d5c9939b530ed3cc2ed8e71162c2264194a3b4c76aL20-R27))
  • Updated template bindings to use signal methods (e.g., currentToken(), darkMode(), profileAvatar(), loggedUserName()) instead of direct property access. ([[1]](https://github.com/switcherapi/switcher-management/pull/444/files#diff-8d554c98f4c32fee762d6a18e8e189f8898124312ba390bdc51fadd38345674fL24-R24), [[2]](https://github.com/switcherapi/switcher-management/pull/444/files#diff-8d554c98f4c32fee762d6a18e8e189f8898124312ba390bdc51fadd38345674fL38-R38), [[3]](https://github.com/switcherapi/switcher-management/pull/444/files#diff-8d554c98f4c32fee762d6a18e8e189f8898124312ba390bdc51fadd38345674fL47-R47), [[4]](https://github.com/switcherapi/switcher-management/pull/444/files#diff-8d554c98f4c32fee762d6a18e8e189f8898124312ba390bdc51fadd38345674fL59-R83), [[5]](https://github.com/switcherapi/switcher-management/pull/444/files#diff-8d554c98f4c32fee762d6a18e8e189f8898124312ba390bdc51fadd38345674fL93-R93), [[6]](https://github.com/switcherapi/switcher-management/pull/444/files#diff-9f07eae3b4f6e8b9b0fd87e68f64b6a3c21ded69e6bfb568d46459883ede9192L2-R4))

Configuration and Polyfills

  • Removed the legacy "zone.js" polyfill from angular.json, likely in favor of zoneless Angular operation. ([angular.jsonL21](https://github.com/switcherapi/switcher-management/pull/444/files#diff-2d2675bb4687601a5c7ccf707455132f90f3516a33716185687e5c41df59ac7dL21))
  • Cleaned up ESLint configuration by removing the directive selector rule, possibly to align with updated Angular standards. ([eslint.config.mjsL16-L22](https://github.com/switcherapi/switcher-management/pull/444/files#diff-9601a8f6c734c2001be34a2361f76946d19a39a709b5e8c624a2a5a0aade05f2L16-L22))

@petruki petruki added this to the v2.2.0 milestone Dec 6, 2025
@petruki petruki self-assigned this Dec 6, 2025
@petruki petruki added the enhancement New feature or request label Dec 6, 2025
@petruki petruki merged commit 48c727b into master Dec 6, 2025
3 checks passed
@petruki petruki deleted the feat_zoneless branch December 6, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants