Skip to content

Fixes default rate limit to accept unlimited rate #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
petruki merged 2 commits into from
Apr 13, 2025
Merged

Fixes default rate limit to accept unlimited rate #556

petruki merged 2 commits into from
Apr 13, 2025

Conversation

@petruki
Copy link
Member

@petruki petruki commented Apr 13, 2025

MAX_REQUEST_PER_MINUTE when set to 0 will allow unlimited API rate.

@petruki petruki added this to the v1.3.1 milestone Apr 13, 2025
@petruki petruki requested a review from Copilot April 13, 2025 22:23
@petruki petruki self-assigned this Apr 13, 2025
Copilot AI reviewed Apr 13, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

@petruki
Update tests/unit-test/limiter/app-limiter-set.test.js
9f550ea 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@petruki petruki requested a review from Copilot April 13, 2025 22:31
Copilot AI reviewed Apr 13, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 13, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@petruki petruki merged commit c1491ea into master Apr 13, 2025
5 checks passed
@petruki petruki deleted the staging branch April 13, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@petruki petruki

Labels

None yet

Projects

None yet

Milestone

v1.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@petruki