Windows: bind BlocksRuntime as an SxS runtime#89987
Conversation
|
@swift-ci please smoke test |
|
Please test with following PRs: @swift-ci please build toolchain Windows platform |
|
Please test with following PRs: @swift-ci please build toolchain Windows ARM64 platform |
1 similar comment
|
Please test with following PRs: @swift-ci please build toolchain Windows ARM64 platform |
|
Please test with following PRs: @swift-ci please build toolchain Windows platform |
compnerd
requested review from
edymtt,
etcwilde and
justice-adams-apple
as code owners
Repair BlocksRuntime.dll with the same generated assembly manifest used for the other Windows SDK runtime DLLs. Include BlocksRuntime in the toolchain SxS runtime graph so executables can bind to it by assembly identity instead of relying on a flat runtime DLL next to the tool.
Add WindowsSxSAssemblyPublicKeyToken as build-time identity metadata for Windows side-by-side assembly manifests. Default it to the placeholder token so local builds do not need access to the signing certificate or catalog signing pipeline. Thread the token through embedded runtime assembly manifests and the dependent assembly references emitted into tool manifests. This keeps assembly definitions and dependency references consistent while leaving code signing as a separate release step.
The resource identifier was being embedded as a string literal rather than the numeric identifier. Include `winuser.h` in the resource file for preprocessing to allow us to get properly generated resources.
Allow embedding the public key identifier into the generated runtime DLLs. This is required for deeper code signing which enables the global native SxS cache.
When building the runtime, we default to the product version for the assembly version. We now wire the product version throughout the build and use that to embed that into the manifest version as well. This is required to get the right version available for the code signing.
|
Please test with following PRs: @swift-ci please build toolchain Windows ARM64 platform |
|
Please test with following PRs: @swift-ci please build toolchain Windows platform |
|
Please test with following PRs: @swift-ci please build toolchain Windows ARM64 platform |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux platform |
|
@swift-ci please smoke test macOS platform |
|
@swift-ci please smoke test Linux platform |
|
@swift-ci please smoke test macOS platform |
1 similar comment
|
@swift-ci please smoke test macOS platform |
|
@swift-ci please smoke test Linux platform |
1 participant
Repair BlocksRuntime.dll with the same generated assembly manifest used for the other Windows SDK runtime DLLs.
Include BlocksRuntime in the toolchain SxS runtime graph so executables can bind to it by assembly identity instead of relying on a flat runtime DLL next to the tool.